Skip to content

run validation2 quickly than before #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025

Conversation

gxyd
Copy link
Collaborator

@gxyd gxyd commented May 27, 2025

Description

With this PR, the validation2 dataset runs much faster than validation dataset, but validation2 can still be used as a way to ensure that POT3D programs produces correct output.

Benchmarks

Machine: M4 MacBook Air with 16GB RAM and 10 cores
Build Command:
FC="${CONDA_PREFIX}/bin/lfortran --cpp -DOPEN_MPI=yes" ./build_and_run_lfortran.sh (with OpenMPI)

Test Case MPI Rank Execution Time (seconds)
validation 1 63.488748
2 35.010407
4 23.125693
validation2 1 12.842186
2 7.535654
4 4.215288

@gxyd gxyd requested a review from certik May 27, 2025 14:45
@gxyd
Copy link
Collaborator Author

gxyd commented May 28, 2025

The CI passes here, I'll merge this.

@gxyd gxyd merged commit 9db0270 into lfortran:main May 28, 2025
8 checks passed
@gxyd gxyd deleted the use_smaller_nt_np_validation2 branch May 28, 2025 03:15
@certik
Copy link
Collaborator

certik commented May 29, 2025

Excellent!

@adit4443ya adit4443ya added the CI label May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants